Restored test checking quota exhaustion #15968

aavdonkin · 2025-03-19T14:31:54Z

Changelog entry

This test checks that writing are disable after exceeding quota and deletions are always enabled

Changelog category

New feature

Description for reviewers

...

github-actions · 2025-03-19T14:32:26Z

⚪ 2025-03-19 14:32:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9dfb2e4 has started.
⚪ 2025-03-19 14:32:56 UTC Artifacts will be uploaded here
⚪ 2025-03-19 14:35:53 UTC ya make is running...
🟡 2025-03-19 14:48:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
79	68	0	1	5	5

⚪ 2025-03-19 14:48:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-19 15:06:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12 (only retried tests)	7	0	1	1	3

⚪ 2025-03-19 15:06:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-19 15:27:33 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
6 (only retried tests)	3	0	1	0	2

🟢 2025-03-19 15:27:44 UTC Build successful.
🟢 2025-03-19 15:27:58 UTC ydbd size 2.1 GiB changed* by +176 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `8ab3977`	merge: `9dfb2e4`	diff	diff %
ydbd size	2 301 025 632 Bytes	2 301 025 808 Bytes	+176 Bytes	+0.000%
ydbd stripped size	481 570 560 Bytes	481 570 624 Bytes	+64 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-19T14:33:05Z

🟢 2025-03-24 09:24:52 UTC The validation of the Pull Request description is successful.

github-actions · 2025-03-19T14:34:52Z

⚪ 2025-03-19 14:34:51 UTC Pre-commit check linux-x86_64-release-asan for 9dfb2e4 has started.
⚪ 2025-03-19 14:35:23 UTC Artifacts will be uploaded here
⚪ 2025-03-19 14:38:06 UTC ya make is running...
🟡 2025-03-19 14:57:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
62	44	0	1	10	7

⚪ 2025-03-19 14:57:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-19 15:11:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20 (only retried tests)	7	0	1	3	9

⚪ 2025-03-19 15:11:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-19 15:29:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14 (only retried tests)	6	0	1	3	4

🟢 2025-03-19 15:29:21 UTC Build successful.
🟢 2025-03-19 15:29:38 UTC ydbd size 3.8 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `8ab3977`	merge: `9dfb2e4`	diff	diff %
ydbd size	4 051 465 528 Bytes	4 051 465 448 Bytes	-80 Bytes	-0.000%
ydbd stripped size	1 401 500 872 Bytes	1 401 500 808 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-19T15:44:51Z

⚪ 2025-03-19 15:44:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7f0d09c has started.
⚪ 2025-03-19 15:45:22 UTC Artifacts will be uploaded here
⚪ 2025-03-19 15:48:09 UTC ya make is running...
🟡 2025-03-19 16:16:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
79	65	0	1	7	6

⚪ 2025-03-19 16:16:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-19 16:31:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15 (only retried tests)	10	0	0	1	4

🟢 2025-03-19 16:31:24 UTC Build successful.
🟠 2025-03-19 16:33:43 UTC Unmuted 1 tests
🟢 2025-03-19 16:33:54 UTC ydbd size 2.1 GiB changed* by +9.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `a95cd74`	merge: `7f0d09c`	diff	diff %
ydbd size	2 301 025 808 Bytes	2 301 035 328 Bytes	+9.3 KiB	+0.000%
ydbd stripped size	481 570 624 Bytes	481 572 864 Bytes	+2.2 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-19T15:45:55Z

⚪ 2025-03-19 15:45:55 UTC Pre-commit check linux-x86_64-release-asan for 7f0d09c has started.
⚪ 2025-03-19 15:46:09 UTC Artifacts will be uploaded here
⚪ 2025-03-19 15:48:21 UTC ya make is running...
🟡 2025-03-19 16:00:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
62	47	0	1	8	6

⚪ 2025-03-19 16:00:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-19 16:12:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16 (only retried tests)	3	0	1	6	6

⚪ 2025-03-19 16:12:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-19 16:33:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15 (only retried tests)	5	0	1	3	6

🟢 2025-03-19 16:33:59 UTC Build successful.
🟢 2025-03-19 16:34:14 UTC ydbd size 3.8 GiB changed* by +17.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `a95cd74`	merge: `7f0d09c`	diff	diff %
ydbd size	4 051 465 544 Bytes	4 051 483 856 Bytes	+17.9 KiB	+0.000%
ydbd stripped size	1 401 500 872 Bytes	1 401 507 400 Bytes	+6.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

dorooleg · 2025-03-20T12:44:31Z

ydb/tests/olap/test_quota_exhaustion.py

@@ -7,8 +7,8 @@
 from ydb.tests.library.harness.kikimr_runner import KiKiMR
 from ydb.tests.library.test_meta import link_test_case

-ROWS_CHUNK_SIZE = 3000000
-ROWS_CHUNKS_COUNT = 100000


А почему тут понадобилось значения менять?

100000 удалений пришлось бы делать, это бы заняло много времени
Изначально предполагалось что на удалениях он будет падать и они выполнятся не все, на самом деле удаления разрешены всегда

dorooleg · 2025-03-20T12:54:42Z

ydb/tests/olap/test_quota_exhaustion.py


    @link_test_case("#13529")
    def test(self):
        """As per https://github.com/ydb-platform/ydb/issues/13529"""
+        self.database_name = '/Root'


Вынеси self.database_name на уровень класса по аналогии с этим примером

Там в разных тестах разное значение используется, поэтому не стал выносить в класс

dorooleg · 2025-03-20T12:56:05Z

ydb/tests/olap/test_quota_exhaustion.py

+            },
+        )
+        self.cluster.register_and_start_slots(self.database_name, count=1)
+        self.cluster.wait_tenant_up(self.database_name)

        # Set soft and hard quotas to 6GB


Тут комменатрий стал не актуален про 6 GB, а уменьшил это значение чтобы тест быстрее проходил?

Да, чтобы быстрее проходил тест

dorooleg · 2025-03-20T12:56:38Z

ydb/tests/olap/test_quota_exhaustion.py


        # Check that deletion works at least first time
-        # self.delete_test_chunk(session, 'huge', 0)
+        self.delete_test_chunk(session, table_path, 0)
        # ^ uncomment after fixing https://github.com/ydb-platform/ydb/issues/13808


Комментарий можно убирать?

ydb/tests/olap/test_quota_exhaustion.py

github-actions · 2025-03-24T09:26:13Z

⚪ 2025-03-24 09:26:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e6734a has started.
⚪ 2025-03-24 09:26:27 UTC Artifacts will be uploaded here
⚪ 2025-03-24 09:28:41 UTC ya make is running...
🟡 2025-03-24 09:55:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
90	84	0	1	2	3

⚪ 2025-03-24 09:55:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-24 10:03:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
7 (only retried tests)	5	0	0	0	2

🟢 2025-03-24 10:03:50 UTC Build successful.
🟠 2025-03-24 10:04:12 UTC Unmuted 1 tests
🟢 2025-03-24 10:04:21 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `a6070b7`	merge: `8e6734a`	diff	diff %
ydbd size	2 319 886 784 Bytes	2 319 886 784 Bytes	0 Bytes	0.000%
ydbd stripped size	484 970 528 Bytes	484 970 528 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-24T09:26:14Z

⚪ 2025-03-24 09:26:13 UTC Pre-commit check linux-x86_64-release-asan for 8e6734a has started.
⚪ 2025-03-24 09:26:29 UTC Artifacts will be uploaded here
⚪ 2025-03-24 09:28:50 UTC ya make is running...
🟡 2025-03-24 09:54:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73	61	0	4	2	6

⚪ 2025-03-24 09:54:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-24 10:08:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13 (only retried tests)	3	0	4	1	5

⚪ 2025-03-24 10:08:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-24 10:23:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12 (only retried tests)	4	0	4	1	3

🟢 2025-03-24 10:23:10 UTC Build successful.
🟢 2025-03-24 10:23:25 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `a6070b7`	merge: `8e6734a`	diff	diff %
ydbd size	4 081 337 152 Bytes	4 081 337 056 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 410 111 528 Bytes	1 410 111 464 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Restored test checking quota exhaustion

47ad108

github-actions bot added the new-feature label Mar 19, 2025

Fixed test

a602fac

dorooleg reviewed Mar 20, 2025

View reviewed changes

ydb/tests/olap/test_quota_exhaustion.py Show resolved Hide resolved

Fixed issues

abb5b8b

github-actions bot added new-feature and removed new-feature labels Mar 24, 2025

aavdonkin linked an issue Mar 24, 2025 that may be closed by this pull request

Data deletion doesn't lead to disk exhaustion #13653

Closed

dorooleg approved these changes Mar 25, 2025

View reviewed changes

aavdonkin merged commit afcf0b0 into ydb-platform:main Mar 25, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restored test checking quota exhaustion #15968

Restored test checking quota exhaustion #15968

aavdonkin commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

dorooleg Mar 20, 2025

aavdonkin Mar 24, 2025

dorooleg Mar 20, 2025

aavdonkin Mar 24, 2025

dorooleg Mar 20, 2025

aavdonkin Mar 24, 2025

dorooleg Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

Restored test checking quota exhaustion #15968

Restored test checking quota exhaustion #15968

Conversation

aavdonkin commented Mar 19, 2025 • edited Loading

Changelog entry

Changelog category

Description for reviewers

github-actions bot commented Mar 19, 2025 • edited Loading

github-actions bot commented Mar 19, 2025 • edited Loading

github-actions bot commented Mar 19, 2025 • edited Loading

github-actions bot commented Mar 19, 2025 • edited Loading

github-actions bot commented Mar 19, 2025 • edited Loading

dorooleg Mar 20, 2025

Choose a reason for hiding this comment

aavdonkin Mar 24, 2025

Choose a reason for hiding this comment

dorooleg Mar 20, 2025

Choose a reason for hiding this comment

aavdonkin Mar 24, 2025

Choose a reason for hiding this comment

dorooleg Mar 20, 2025

Choose a reason for hiding this comment

aavdonkin Mar 24, 2025

Choose a reason for hiding this comment

dorooleg Mar 20, 2025 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Mar 24, 2025 • edited Loading

github-actions bot commented Mar 24, 2025 • edited Loading

aavdonkin commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025 •

edited

Loading

dorooleg Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading